fix: use retry loop when loading deletion files #2899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2899 +/- ##
==========================================
- Coverage 77.93% 77.92% -0.02%
==========================================
Files 231 231
Lines 70613 70612 -1
Branches 70613 70612 -1
==========================================
- Hits 55031 55022 -9
+ Misses 12462 12457 -5
- Partials 3120 3133 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wjones127
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading deletion files we were directly accessing
ObjectStore::innerwhich bypasses the retry loop. This makes loading deletion files somewhat brittle and was causing issues in scans (which can load a lot of deletion files at the same time they are loading lots of other ranges).This PR changes the deletion file load to use the
ObjectStoreand adds convenience methods to make this easier in the future.In the future we should also move this load to use a
FileSchedulerinstead ofObjectStoreso that these deletion file loads do not violate our max-iops-per-scan but that can be done later.